Support Silex 2

[naxhh]

So, the adapter seems very nice feature to have and avoid coupling to controllers but it does not work with silex 2 (composer.json specify silex 1.3)

Is any plan to make it work with silex 2?

[mnapoli]

Hi, that's a good idea. I don't have the time to look into that at the moment but feel free to give it a shot?

[jdreesen]

There has already been done some work in https://github.com/PHP-DI/Silex-Bridge/tree/silex-2. However, I'm not sure what's missing (if at all) and I'm currently pretty busy with my day job (plus I haven't used Silex 2 in any project for a while).

[mnapoli]

Oh right sorry! There's even a beta release, @naxhh could you try it: https://github.com/PHP-DI/Silex-Bridge/releases/tag/2.0.0-beta1

[naxhh]

Sure. I'll try to test it this weekend and report back :)

EDIT: Hadn't have time that weekend let's see how this one goes...

[kordos]

Any progress with moving to silex 2?

[naxhh]

Hi! I was on holidays and in that time I abandoned that project so I didn't had the requirement to test this anymore.

I'm ok closing this issue or just keeping it open in case someone wants to test this.

[mnapoli]

👍 no worries, let's keep this issue open though.

[kordos]

Hi, I added pull request with silex 2 support. It works perfectly with my service.
Please review my pull request.

[mnapoli]

@kordos have you seen the changes in this branch: https://github.com/PHP-DI/Silex-Bridge/commits/silex-2 ? Maybe there are some things to keep from there.

[kordos]

Yes. My pull request is from this branch(silex-2)

[kordos]

@mnapoli or @jdreesen can you merge my pull request with silex 2 support?

[mnapoli]

Done. @jdreesen is the current status of the silex-2 branch good for you? We could tag a release (even a beta if we are not 100% confident) to get things moving?

[kordos]

It works perfectly in one of my projects. I didn't see any problems yet. In near future I will migrate other microservices to silex 2 and test it in production. I'm wondering what tag it should get. Definitely I'm not using all features of silex 2 so I'm not 100% sure that everything works(but it works for my usage). At least we can tag it beta2 and after some time if no errors come up we can tag it as 2.0.0. @mnapoli what do you think?

[kordos]

@jdreesen or @mnapoli can you add tag to silex-2 branch? I don't have permissions for it

[mnapoli]

@kordos The silex branch is behind master: silex-2...master (there are commits in master that were not integrated in this branch) => could you reintegrate those commits into the branch ? (via a pull request for example, but github tells me there are conflicts to solve)

I'm also wondering whether it makes sense to continue tu support Silex since it's now deprecated 🤔