Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility of python ismrmrd with xsdata causes test failures #174

Closed
fzimmermann89 opened this issue Feb 17, 2024 · 2 comments · Fixed by #177
Closed

Incompatibility of python ismrmrd with xsdata causes test failures #174

fzimmermann89 opened this issue Feb 17, 2024 · 2 comments · Fixed by #177

Comments

@fzimmermann89
Copy link
Member

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/data/_IsmrmrdRawTestData.py:213: in __init__
    dset.write_xml_header(header.toXML('utf-8'))
/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/ismrmrd/xsd/pyxb_compat.py:18: in ToXML
    config = SerializerConfig(encoding=encoding,pretty_print=True)
<string>:11: in __init__
    ???
/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/xsdata/formats/dataclass/serializers/config.py:40: in __post_init__
    self.__setattr__("pretty_print", pretty_print)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = SerializerConfig(encoding='utf-8', xml_version='1.0', xml_declaration=True, indent=None, ignore_default_attributes=False, schema_location=None, no_namespace_schema_location=None, globalns=None)
key = 'pretty_print', value = True

    def __setattr__(self, key: str, value: Any):
        """Handle deprecated pretty print/indent behaviour."""
        if key == "pretty_print":
>           warnings.warn(
                "Setting `pretty_print` is deprecated, use `indent` instead",
                DeprecationWarning,
            )
E           DeprecationWarning: Setting `pretty_print` is deprecated, use `indent` instead

/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/xsdata/formats/dataclass/serializers/config.py:47: DeprecationWarning
@fzimmermann89
Copy link
Member Author

@fzimmermann89
Copy link
Member Author

fzimmermann89 commented Feb 17, 2024

I'd say we ignore these failures for now manually and wait for a fix in ismrmrd python

fzimmermann89 added a commit that referenced this issue Feb 20, 2024
schuenke pushed a commit that referenced this issue Feb 20, 2024
* Limit xsd version

Fixes #174

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fzimmermann89 added a commit that referenced this issue Nov 10, 2024
* Limit xsd version

Fixes #174

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant