Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused radial undersampling parameter from KTrajectorySunflowerGoldenRpe #563

Open
fzimmermann89 opened this issue Nov 27, 2024 · 3 comments
Assignees

Comments

@fzimmermann89
Copy link
Member

fzimmermann89 commented Nov 27, 2024

In KTrajectorySunflowerGoldenRpe, you can set an unused undersampling parameter.

I am currently refactoring the acq_info and trajectory calculators.
For now, I will only throw an notimplementederror if the undersampling factor is set to anything but 1.0,
Later on, this parameter should either be removed or implemented.

self.rad_us_factor: float = rad_us_factor

@fzimmermann89
Copy link
Member Author

@ckolbPTB Or am i missing how it is supposed to work?

@ckolbPTB
Copy link
Collaborator

Must be left over from something we in the end did not use. Feel free to already remove the parameter during the refactoring.

on a side note: RPE is not a radial trajectory but a Cartesian trajectory

@fzimmermann89
Copy link
Member Author

No I am confused - maybe I misunderstood RPE.

I always thought RPE is readout lines in kz direction going through points in the kx plane that are arranged in a radial pattern.
So you have to do a fft along kz followed by 2d Nufft along kxky

Why is this considered Cartesian?

Are kxky acquired pseudo radial on Cartesian grid points? This would make it a bit difficult to describe the pattern - how do you do the rounding to grid coordinates? There is some ambiguity...

@fzimmermann89 fzimmermann89 changed the title Support radial undersampling remve unused radial undersampling parameter from KTrajectorySunflowerGoldenRpe Dec 2, 2024
@fzimmermann89 fzimmermann89 changed the title remve unused radial undersampling parameter from KTrajectorySunflowerGoldenRpe remove unused radial undersampling parameter from KTrajectorySunflowerGoldenRpe Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants