Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output improperly sanitized #56

Open
bramz opened this issue Feb 26, 2019 · 1 comment
Open

Output improperly sanitized #56

bramz opened this issue Feb 26, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bramz
Copy link
Contributor

bramz commented Feb 26, 2019

Describe the bug
Some characters are being rendered allowing uploaded content to inject or render data on the page.

To Reproduce
http://cdn.paste.click/ZJ2qGKLleIoaDRRbkVp5GQ

Expected behavior
Should render simple plain text with all characters properly escaped/sanitized.

Screenshots
https://cdn.discordapp.com/attachments/523599882162929664/549847817078702080/unknown.png

@bramz bramz added the bug Something isn't working label Feb 26, 2019
@ncatelli
Copy link

We should probably just add a rule to the readHandler. We are essentially just pulling the mimetype from the stored object. I can do a hotfix for this and then a subsequent better fix to add minimal rules to objects for filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants