Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No extension on filename #67

Open
Tiksi opened this issue Mar 13, 2019 · 0 comments
Open

No extension on filename #67

Tiksi opened this issue Mar 13, 2019 · 0 comments
Labels
bug Something isn't working ui

Comments

@Tiksi
Copy link
Contributor

Tiksi commented Mar 13, 2019

Describe the bug
When trying to download a file, the content-disposition header is being set the filename lacking the extension. If trying to download arbitrary file types (zip, rar, tar), this can be confusing if you don't know the file type ahead of time.

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://cdn.paste.click/fBbjLt7FifSV6cWTXoIDdQ or any other url in a browser
  2. Try to "save as"
  3. Notice the file doesn't have an extension

Expected behavior
The file should have the correct extension.

Additional context
GCS allows a Content-Disposition header to be set on objects, we should set this with the correct filename with the extension derived from the mimetype determined by mimemagic and passed along to the client in nginx, removing the current content-disposition mapping in nginx as it relies on the old way of storing files locally (with their extension).

@Tiksi Tiksi added bug Something isn't working ui labels Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui
Projects
None yet
Development

No branches or pull requests

1 participant