New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of validation in SshCommandExpectation #23

Open

scotthellman opened this issue Feb 14, 2017 · 0 comments

Contributor

scotthellman commented Feb 14, 2017

We include the validation in the constructor for SshCommandExpectation, but then appear to use it inconsistently:

https://github.com/PearsonEducation/Alarmageddon/blob/dev/alarmageddon/validations/ssh.py#L309
vs
https://github.com/PearsonEducation/Alarmageddon/blob/dev/alarmageddon/validations/ssh.py#L307

We should either always use self.validation or always have the validation as a parameter to SshCommandExpectation's methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment