docker.yml Dockerhub Integration

[Sweetdevil144]

Description

Is your feature request related to a problem? Please describe.
Current Workflow gives me an error Error: Username and password required while trying to Login into DockerHub.

Proposed Solution

Maybe we can enhance this by providing user an option to use their DOCKER_USERNAME or DOCKER_PASSWORD from secrets. Maybe further additions as below :

jobs:
  docker_login:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v3
      - name: Log in to Docker
        uses: docker/login-action@v3
        with:
          username: ${{ secrets.DOCKER_USERNAME }}
          password: ${{ secrets.DOCKER_PASSWORD }}

[Sweetdevil144]

@allgandalf @infotroph any recommendations?

[allgandalf]

how would this help for forked repos?

the problem is the secrets only exist within the main repo, and forked repos do not have access to these secrets.

So how will this change help us? or did i misunderstand this issue?

[Sweetdevil144]

Then maybe restrict the access here as well to pecanProject/pecan only?

[allgandalf]

yea, that would be the best way forward actually

[Sweetdevil144]

I'll reference these changes in #3405