Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the use of Console vs logger #365

Open
rgreinho opened this issue Sep 27, 2023 · 1 comment
Open

Review the use of Console vs logger #365

rgreinho opened this issue Sep 27, 2023 · 1 comment
Assignees
Labels
kind/enhancement Improve an existing feature

Comments

@rgreinho
Copy link
Member

rgreinho commented Sep 27, 2023

Feature request

Current Behavior/ Expected Behavior

The logger is used in most places, but some times a Console would be more appropriate.

For instance, in the run-with cli module, messages like logger.info("Run with compose") or logger.info("Run with original BNA") could be replaced with with console.status("[bold green]Run with compose").

Or the configure module does not display any information, leaving the user without feedback.

We should make sure that the appropriate system is being use to provide the best user experience.

@rgreinho rgreinho added the kind/enhancement Improve an existing feature label Sep 27, 2023
@rgreinho rgreinho added this to the v2-rc - TUI enhancements milestone Sep 27, 2023
@rgreinho
Copy link
Member Author

Another thing would be to make the CLI command composable when possible. For example, the run and run-with sub-commands mostly simply call other sub-commands.

If we could create small reusable units, then we would be able to assemble them like Lego blocks.

@rgreinho rgreinho assigned rgreinho and lalver1 and unassigned rgreinho Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improve an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants