Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High DPI screens cause the app to scale, which includes intermediatory files for rendering #71

Open
Magimedia opened this issue Oct 18, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Magimedia
Copy link

Describe the bug
High DPI screens cause the app to scale, which includes intermediatory files for rendering

To Reproduce
Open the App on any high resolution screen which has scaling set (eg a 1920x1080 15" screen typically has 125% scaling setby the OS). 1920x1080 output resolution produced jpegs at 2400x1350 at the rendering stage, and the scaling up then down to produce the mp4 introduces artifacts and distortion.

Expected behavior
The app and rendered intermidiate files should not be scaled.

Desktop (please complete the following information):

  • OS: Windows 11, laptop at 1920 z 1080, default 125dpi

Additional context

Adding the following two lines into main.js around line 50cwill fix the issue:

app.commandLine.appendSwitch('high-dpi-support', 1);
app.commandLine.appendSwitch('force-device-scale-factor', 1);

@Magimedia Magimedia added the bug Something isn't working label Oct 18, 2024
@Picorims
Copy link
Owner

Thanks for the report and the hint, this one is quite annoying indeed, I added it to the rewrite board to also fix it on legacy. I will most likely look into it once I'm done with the current ticket I am working on in the rewrite.

@Picorims Picorims added this to the 0.3.4-beta milestone Oct 18, 2024
@Magimedia
Copy link
Author

Glad to help! This is proving a useful way to create videos for telephone interviews, rather than just a static image of the interviewee. Thanks for such a great little program!

I can confirm the fix above works. I've tried it on our three different Win10 and Win11 laptops and it worked perfectly. It also went slightly faster, presumably as it wasn't resizing images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

2 participants