Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of SpanCallback #6

Open
remcomokveld opened this issue Mar 9, 2017 · 0 comments
Open

Improve documentation of SpanCallback #6

remcomokveld opened this issue Mar 9, 2017 · 0 comments

Comments

@remcomokveld
Copy link

from the docs/method name it is not really clear that you have to return the span also if you did not modify/replace it. Normally the name Callback suggests that it is just a notification while this function actually alters the bahavior. Maybe something like SpanHandler would be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants