Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a battle turn number counter #107

Open
SilverDeoxys563 opened this issue Mar 24, 2021 · 1 comment
Open

Implement a battle turn number counter #107

SilverDeoxys563 opened this issue Mar 24, 2021 · 1 comment
Labels
feature request When you have a request for features that could be added

Comments

@SilverDeoxys563
Copy link

If the end of the 10th turn is reached in a battle, currently the program will be surprised that it's wiped out with non-zero lives and throw out a warning and keep going. While the current operation doesn't break anything, it could be optimized to avoid throwing this warning if a simple for loop were added that increments a counter the turn counter every time the Fight symbol gets detected. That way, it can be prepared for no "Catch / Don't Catch" menu popping up on Turn 10, and the program can safely switch to the next mode without a warning in conjunction with the detection of the black screen.

I do think it's important to leave the current black screen detection in to end the run, because if for some freak reason if the Fight symbol gets detected an eleventh time (which won't happen), this setup should handle a case like that to keep fighting anyway since no black screen would have been detected at that point.

@denvoros denvoros added the feature request When you have a request for features that could be added label Mar 25, 2021
@ercdndrs
Copy link
Collaborator

ercdndrs commented Apr 4, 2021

We might be able to add a turn counter when we start using the battle text to learn more about stat changes et cetera. We would have to account for 2-turn moves and Outrage/Petal Dance since they take multiple turns but only show the "Fight" symbol once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request When you have a request for features that could be added
Projects
None yet
Development

No branches or pull requests

3 participants