Bump and reduce dependencies #171

doamatto · 2023-07-23T01:17:28Z

Type of pull request: maintenance

Related issues: #170, #169, #151, #150, #149, #80, #181, #186, #191, #192, #193
Related repos: neutralis/hbl-strings, neutralis/hbl-maths, neutralis/hbl-object, neutralis/hbl-cmark, neutralis/hbl-arrays, neutralis/hbl-comparison, neutralis/hbl-urls

† = not public/done yet

It seems they are only used in src/build/icons.ts, which is never called by anything. My understanding is that this is meant to be run on its own to help with making products. Maybe I can split this off into something else in the future – I've wanted to make a GUI for people to do rubrics for awhile that would make PRs easier to handle, but we'll see. For now, the deps have been moved.

I'm going to try and migrate to 1.y.z and get us even closer to the proper main version. Ve vill see.

…got it back

doamatto · 2025-01-15T00:42:40Z

Packages are all OK™. A few quirks to deal with, but hopefully we're nearing the end of this very-long-delayed MR.

Several hot-fixes were made to add compatibility with `handlebars-wax` (which `gulp-hb` uses) and ensure helpers were brought inline with their predecessor

Seems to be unused. Will reinstall if it causes problems

Shouldn't be an issue for a hot while

We aren't too concerned about this stuff. Ideally, this should be either removed or moved elsewhere in the future since these migrations are, as far as I'm aware, long done.

milesmcc · 2025-01-21T06:27:13Z

Thanks for doing this!

doamatto · 2025-01-21T17:19:28Z

Found some quirky stuff while working offline. The command I've been using to build (NODE_ENV="development" LOG_LEVEL="debug" npx cross-env NODE_OPTIONS="--trace-deprecation --trace-warnings" npx gulp) weirdly doesn't work.

Supposedly the fix is linking ts-node (npm link ts-node) but that yielded an error that explains why I've seen another error.

doa@litten ~/git/politiwatch/privacyspy % npm link ts-node                                             
npm error code 127
npm error path /Users/doa/.nvm/versions/node/v22.2.0/lib/node_modules/ts-node
npm error command failed
npm error command sh -c npm run clean && npm run build-nopack
npm error > [email protected] clean
npm error > rimraf temp dist tsconfig.schema.json tsconfig.schemastore-schema.json tsconfig.tsbuildinfo tests/ts-node-packed.tgz tests/node_modules tests/tmp
npm error sh: rimraf: command not found
npm error A complete log of this run can be found in: /Users/doa/.npm/_logs/2025-01-21T17_15_50_724Z-debug-0.log

rimraf has shown up as the only reasonable source of tasks not completing like this :

Did you forget to signal async completion?
TypeError: callback is not a function
    at CB (node:internal/fs/rimraf:60:5)
    at FSReqCallback.oncomplete (node:fs:188:23)
    at FSReqCallback.callbackTrampoline (node:internal/async_hooks:130:17)

Will likely spend some time updating the README to add some useful commands for people building locally in the future, as well as getting things to work again within the CI/CD. All that to say — I have no clue what caused this (iirc it was a problem before switching to npx for gulp too)

I think migrating to esbuild over time *could* help mitigate some issues, the most notable one being the weird requirement for a network connection to build PrivacySpy (which is ridiculous in general). deps:

chore: rename css.ts -> scss.ts

doamatto · 2025-01-26T19:55:02Z

Words cannot describe the amount of disgust and distain the fix for this was. That is to say — using fs.rmSync in place of fs.rm has fixed this problem entirely and builds should now clear.

Will investigate not being able to build offline (Loaded external module: ts-node/register being the likely culprit) and just might be done after that

- Removes esbuild system (may™ return in future) - Moves SASS back to src/static/css/ (rather than src/css/) - Re-adds PostCSS, Gulp tasks for SASS transpilation

doamatto · 2025-01-26T20:54:26Z

We are oh so close. npx gulp finishes fine locally (gulp in 2.8s, compared to last prod deploy of gulp in 11s) but fails on Netlify with :

12:50:31 PM: /opt/build/repo/node_modules/hbl-cmark/dist/index.js:1
12:50:31 PM: var w=Object.defineProperty;var v=Object.getOwnPropertyDescriptor;var f=Object.getOwnPropertyNames;var o=Object.prototype.hasOwnProperty;var c=(r,e)=>{for(var a in e)w(r,a,{get:e[a],enumerable:!0})},u=(r,e,a,t)=>{if(e&&typeof e=="object"||typeof e=="function")for(let n of f(e))!o.call(r,n)&&n!==a&&w(r,n,{get:()=>e[n],enumerable:!(t=v(e,n))||t.enumerable});return r};var S=r=>u(w({},"__esModule",{value:!0}),r);var l={};c(l,{default:()=>g,register:()=>m});module.exports=S(l);var s=require("commonmark"),i=require("node:fs"),p=require("node:path"),q=require("handlebars");function g(r){r.registerHelper("markdown",e=>{var a=new s.Parser,t=new s.HtmlRenderer,n=a.parse(e.fn(this));return new r.SafeString(t.render(n))}),r.registerHelper("md",e=>{var a=p.resolve(process.cwd(),e);data=i.readFileSync(a,"utf8");var t=new s.Parser,n=new s.HtmlRenderer,d=t.parse(data);return new r.SafeString(n.render(d))})}function m(r){r.registerHelper("markdown",e=>{var a=new s.Parser,t=new s.HtmlRenderer,n=a.parse(e.fn(this));return new r.SafeString(t.render(n))}),r.registerHelper("md",e=>{var a=p.resolve(process.cwd(),e);data=i.readFileSync(a,"utf8");var t=new s.Parser,n=new s.HtmlRenderer,d=t.parse(data);return new r.SafeString(n.render(d))})}0&&(module.exports={register});
12:50:31 PM:                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ^
12:50:31 PM: <ref *2> PluginError [TypeError]: e.fn is not a function
12:50:31 PM:     at String.<anonymous> (/opt/build/repo/node_modules/hbl-cmark/dist/index.js:1:1003)
12:50:31 PM:     at String.wrapper (/opt/build/repo/node_modules/handlebars/lib/handlebars/internal/wrapHelper.js:10:19)
12:50:31 PM:     at eval (eval at createFunctionContext (/opt/build/repo/node_modules/handlebars/lib/handlebars/compiler/javascript-compiler.js:265:23), <anonymous>:11:133)
12:50:31 PM:     at prog (/opt/build/repo/node_modules/handlebars/lib/handlebars/runtime.js:333:12)
12:50:31 PM:     at execIteration (/opt/build/repo/node_modules/handlebars/lib/handlebars/helpers/each.js:50:9)
12:50:31 PM:     at Object.<anonymous> (/opt/build/repo/node_modules/handlebars/lib/handlebars/helpers/each.js:63:13)
12:50:31 PM:     at Object.wrapper (/opt/build/repo/node_modules/handlebars/lib/handlebars/internal/wrapHelper.js:10:19)
12:50:31 PM:     at eval (eval at createFunctionContext (/opt/build/repo/node_modules/handlebars/lib/handlebars/compiler/javascript-compiler.js:265:23), <anonymous>:11:49)
12:50:31 PM:     at Object.prog [as fn] (/opt/build/repo/node_modules/handlebars/lib/handlebars/runtime.js:333:12)
12:50:31 PM:     at Object.<anonymous> (/opt/build/repo/node_modules/handlebars/lib/handlebars/helpers/if.js:19:22) {
12:50:31 PM:   __safety: undefined,
12:50:31 PM:   _stack: undefined,
12:50:31 PM:   plugin: 'gulp-hb',
12:50:31 PM:   showProperties: true,
12:50:31 PM:   showStack: true,
12:50:31 PM:   fileName: '/opt/build/repo/src/templates/pages/product.hbs',
12:50:31 PM:   domainEmitter: <ref *1> Transform {
12:50:31 PM:     _events: [Object: null prototype] {
12:50:31 PM:       newListener: [Function: newListener],
12:50:31 PM:       pipe: [Function]
12:50:31 PM:     },
12:50:31 PM:     _eventsCount: 2,
12:50:31 PM:     _maxListeners: undefined,
12:50:31 PM:     _duplexState: 918036,
12:50:31 PM:     _readableState: ReadableState {
12:50:31 PM:       stream: [Circular *1],
12:50:31 PM:       queue: [FastFIFO],
12:50:31 PM:       highWaterMark: 0,
12:50:31 PM:       buffered: 0,
12:50:31 PM:       readAhead: true,
12:50:31 PM:       error: [Circular *2],
12:50:31 PM:       pipeline: [Pipeline],
12:50:31 PM:       byteLength: [Function: defaultByteLength],
12:50:31 PM:       map: null,
12:50:31 PM:       pipeTo: [DestroyableTransform],
12:50:31 PM:       afterRead: [Function: bound afterRead],
12:50:31 PM:       afterUpdateNextTick: [Function: bound updateReadNT]
12:50:31 PM:     },
12:50:31 PM:     _writableState: WritableState {
12:50:31 PM:       stream: [Circular *1],
12:50:31 PM:       queue: [FastFIFO],
12:50:31 PM:       highWaterMark: 0,
12:50:31 PM:       buffered: 0,
12:50:31 PM:       error: [Circular *2],
12:50:31 PM:       pipeline: null,
12:50:31 PM:       drains: null,
12:50:31 PM:       byteLength: [Function: defaultByteLength],
12:50:31 PM:       map: null,
12:50:31 PM:       afterWrite: [Function: bound afterWrite],
12:50:31 PM:       afterUpdateNextTick: [Function: bound updateWriteNT]
12:50:31 PM:     },
12:50:31 PM:     _predestroy: [Function: predestroy],
12:50:31 PM:     _transformState: TransformState {
12:50:31 PM:       data: null,
12:50:31 PM:       afterTransform: [Function: bound afterTransform],
12:50:31 PM:       afterFinal: [Function: bound afterFinal]
12:50:31 PM:     },
12:50:31 PM:     _flush: [Function: flush],
12:50:31 PM:     _read: [Function (anonymous)],
12:50:31 PM:     [Symbol(shapeMode)]: false,
12:50:31 PM:     [Symbol(kCapture)]: false
12:50:31 PM:   },
12:50:31 PM:   domainThrown: false
12:50:31 PM: }

doamatto added 3 commits July 22, 2023 18:10

chore: regenerate package lock

2912214

fix: email and website for self

263c15b

deps: add missing dep for buildtime

5ee1741

doamatto added 3 commits August 6, 2023 09:35

deps: swap to maintained version of gulp-compile-handlebars

2574062

chore: add npm run build to make builds marginally easier

e4816e2

deps: regenerate package lock

07abdee

doamatto self-assigned this Aug 6, 2023

doamatto added size/M dependencies Pull requests that update a dependency file labels Aug 6, 2023

doamatto and others added 6 commits August 6, 2023 10:27

chore: start migration to latest of a17t

35ae248

fix: ran self-check npm test (npm audit fix)

acf0ed2

chore: bump axios to 0.28.1

90c2136

I'm going to try and migrate to 1.y.z and get us even closer to the proper main version. Ve vill see.

chore: bump axios to latest (1.6.8)

edf0096

fix: bump timeout from 10ms to 10000ms/10s

9190309

doamatto mentioned this pull request Apr 20, 2024

chore(deps): bump axios from 0.21.2 to 1.6.0 #178

Closed

doamatto added 7 commits April 19, 2024 18:28

fix: found out where the rest of the package lockfile went, err well …

9f1e597

…got it back

chore: bump node version for GH action

c570e89

chore: update some Babel deps to latest

7c6a5d2

chore: move Jest to devdep

b8d99e4

chore: update typings deps

5488ec6

chore: move eslint to develop

a659e69

chore: swap out handlebars-helpers

ec26f4b

This was referenced Sep 9, 2024

chore(deps): bump ws from 7.5.0 to 7.5.10 #186

Closed

chore(deps): bump follow-redirects from 1.14.8 to 1.15.4 #181

Closed

This was referenced Jan 15, 2025

chore(deps): bump nanoid from 3.3.6 to 3.3.8 #206

Closed

chore(deps): bump es5-ext from 0.10.53 to 0.10.64 #192

Closed

doamatto added 14 commits January 14, 2025 17:15

deps: bump

2755a1d

chore: remove comments for formerly not-made packages

fc1458a

deps: bump all hbl-* packages

a299a7c

Several hot-fixes were made to add compatibility with `handlebars-wax` (which `gulp-hb` uses) and ensure helpers were brought inline with their predecessor

deps: bump several dependencies, remove dotenv dependency

8a307f0

chore: replace gulp-rename with homebrew solution

6f3fc0f

deps: remove gulp-rename

776b2f6

deps: remove gulp-jest, bumps

10732c8

Seems to be unused. Will reinstall if it causes problems

chore: pin Ubuntu to squelch build warning

cc78d67

Shouldn't be an issue for a hot while

chore: bump setup-node, remove actions/cache in favour of

0277807

deps: bump and remove fluff from ESLint, TypeScript-ESLint, Prettier

1df3203

fix: remove unused vars

afffb6e

chore: squelch error from legacy codebase

13e6059

We aren't too concerned about this stuff. Ideally, this should be either removed or moved elsewhere in the future since these migrations are, as far as I'm aware, long done.

fix: use unused vars for error catching/reporting

7d70ea9

deps: remove Babel (was unused)

8815a52

doamatto added 3 commits January 21, 2025 19:32

chore: move Gulp tasks for SCSS transpile, moving assets to esbuild

11f35ee

I think migrating to esbuild over time *could* help mitigate some issues, the most notable one being the weird requirement for a network connection to build PrivacySpy (which is ridiculous in general). deps:

fix: add missing fs, path imports

080c292

chore: rename css.ts -> scss.ts

c3cad72

chore: rename css.ts -> scss.ts

doamatto added 6 commits January 26, 2025 11:55

fix: callback is not function

3d637e3

fix: Jest tests, the return of Babel

2c98280

chore: partial revert of 11f35ee

b7ae2ce

- Removes esbuild system (may™ return in future) - Moves SASS back to src/static/css/ (rather than src/css/) - Re-adds PostCSS, Gulp tasks for SASS transpilation

fix: move PostCSS config into gulpfile

a9e948e

deps: bump Node version for test workflow

2402f10

chore: set NVM to 22 (for Netlify)

794defe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump and reduce dependencies #171

Bump and reduce dependencies #171

doamatto commented Jul 23, 2023 •

edited

Loading

doamatto commented Jan 15, 2025

milesmcc commented Jan 21, 2025

doamatto commented Jan 21, 2025

doamatto commented Jan 26, 2025

doamatto commented Jan 26, 2025

Bump and reduce dependencies #171

Are you sure you want to change the base?

Bump and reduce dependencies #171

Conversation

doamatto commented Jul 23, 2023 • edited Loading

doamatto commented Jan 15, 2025

milesmcc commented Jan 21, 2025

doamatto commented Jan 21, 2025

doamatto commented Jan 26, 2025

doamatto commented Jan 26, 2025

doamatto commented Jul 23, 2023 •

edited

Loading