Replace get_env_config() with resolve_env_vars().
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ap/liger_ce
samsja
reviewed
Jan 16, 2025
src/zeroband/config.py
Outdated
|
|
||
| for field_name, _ in config_obj.__class__.model_fields.items(): | ||
| # Build the full env var name | ||
| full_env_var = f"ZERO_BAND_{prefix}_{field_name}".upper() if prefix else f"ZERO_BAND_{field_name}".upper() |
There was a problem hiding this comment.
can you make ZERO_BAND ad const var somewhere ? In case where we finally rename the whole thing to prime
There was a problem hiding this comment.
Yeah, will do. Makes a lot of sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autism wins yet again. This is the last time though.
Instead of resolving the env vars as you access them with get_env_config(), let's just resolve them all at the beginning and do
config.thing. The env var for that is stillZERO_BAND_THING, as before. But now we don't have to replace every place the config is accessed.Because screw that, honestly. This is way better, and is what it should have been in the first place.