Porting of the X-Ray Latent Diffusion Models model from MONAI Generative Models into model-zoo. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s repo. Signed-off-by: Virginia <[email protected]>
… that no longer applies.
for more information, see https://pre-commit.ci
ericspod
reviewed
Dec 9, 2024
models/cxr_image_synthesis_latent_diffusion_model/configs/inference.json
Outdated
Show resolved
Hide resolved
ericspod
reviewed
Dec 9, 2024
models/cxr_image_synthesis_latent_diffusion_model/configs/metadata.json
Outdated
Show resolved
Hide resolved
ericspod
reviewed
Dec 9, 2024
models/cxr_image_synthesis_latent_diffusion_model/configs/inference.json
Outdated
Show resolved
Hide resolved
ericspod
reviewed
Dec 9, 2024
models/cxr_image_synthesis_latent_diffusion_model/docs/README.md
Outdated
Show resolved
Hide resolved
… longer necessary. On inference, modification of the entry point from save_jpg to run to allow for run to be called alone, and truncation of loading statements which are too long. Modification of the README to include command example changes.
…z/model-zoo into xray_classifier_port
for more information, see https://pre-commit.ci
KumoLiu
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Thanks for the contribution. Would be great to add corresponding test here:
https://github.com/Project-MONAI/model-zoo/tree/dev/ci/unit_tests
KumoLiu
reviewed
Dec 12, 2024
| large_files: | ||
| - path: "models/autoencoder.pth" | ||
| url: "https://drive.google.com/uc?export=download&id=1paDN1m-Q_Oy8d_BanPkRTi3RlNB_Sv_h" | ||
| hash_val: "" |
There was a problem hiding this comment.
Please also include the hash val here.
KumoLiu
reviewed
Dec 12, 2024
| "schema": "https://github.com/Project-MONAI/MONAI-extra-test-data/releases/download/0.8.1/meta_schema_20220324.json", | ||
| "version": "1.0.0", | ||
| "changelog": { | ||
| "0.2": "Flipped images fixed" |
There was a problem hiding this comment.
Should also include "1.0.0" here?
added 2 commits
December 17, 2024 08:44
For metadata, adjusted the versions, setting current to Initial Release. I also removed nibabel from the optional package requirements as this CXR produces JPG and does not deal with nifti files.
…z/model-zoo into xray_classifier_port
| @@ -0,0 +1,110 @@ | |||
| { | |||
| "imports": [ | |||
There was a problem hiding this comment.
Hi @virginiafdez , thanks for the PR. Could you also help to add a test file? The purpose is to ensure the bundle is runnable, and here is an example:
https://github.com/Project-MONAI/model-zoo/blob/dev/ci/unit_tests/test_spleen_ct_segmentation.py#L37
…erify_bundle to pass the check for model.pt, since the requirement for two models (autoencoder and diffusion_model) makes sense for them to keep their specific names. Modification of inference.json to add dummy attributes to pass the ConfigWorkflow check. Modification of large_files.yml so that models are .pt and not .pth.
…erify_bundle to pass the check for model.pt, since the requirement for two models (autoencoder and diffusion_model) makes sense for them to keep their specific names. Modification of inference.json to add dummy attributes to pass the ConfigWorkflow check. Modification of large_files.yml so that models are .pt and not .pth.
for more information, see https://pre-commit.ci
|
It still fails on the verify_bundle because I can only write one exception and there are two models that need to be downloaded that are not named model.pt. |
added 2 commits
January 14, 2025 08:34
Add LICENSE file.
Modification of diffusion_model.pt name to model.pt to go through the verify_bundle Python function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the porting of MONAI Generative Models, the models present in the model zoo from that repo (https://github.com/Project-MONAI/GenerativeModels/tree/main/model-zoo) need to be ported into the main model zoo from MONAI.
This is one of the models, a latent diffusion model that generates X-Rays.
Status
**Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").