Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fate(core/lint): simplify Boolean comparisons #55

Open
gretmn102 opened this issue Sep 30, 2024 · 0 comments
Open

fate(core/lint): simplify Boolean comparisons #55

gretmn102 opened this issue Sep 30, 2024 · 0 comments

Comments

@gretmn102
Copy link
Collaborator

gretmn102 commented Sep 30, 2024 •
edited
Loading

Suggest the following replacements:

  • Expression isNum($str) = -1 on isNum($str)
  • Expression isNum($str) = 0 on no isNum($str)

The first case is worth especially because isNum in 7.9, for example, returns 1 instead of -1, which leads to incorrect calculations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gretmn102