Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Vivecraft: Error reading origin info: InvalidHandle if one or more controllers are asleep #596

Open
thejudge156 opened this issue Jun 5, 2024 · 0 comments
Assignees
Labels
bug Something isn't working fixed This bug has been fixed in a new release.

Comments

@thejudge156
Copy link
Contributor

🤔 Current Behavior

If a controller is asleep, the following error is thrown and the game crashes.

[13:30:16] [Render thread/ERROR]: Unreported exception thrown! java.lang.RuntimeException: Error reading origin info: InvalidHandle at org.vivecraft.client_vr.provider.openvr_lwjgl.MCOpenVR.readOriginInfo(MCOpenVR.java:1094) ~[Vivecraft.jar:?] at org.vivecraft.client_vr.provider.openvr_lwjgl.MCOpenVR.getOriginControllerType(MCOpenVR.java:1275) ~[Vivecraft.jar:?] at org.vivecraft.client_vr.provider.openvr_lwjgl.VRInputAction.isEnabled(VRInputAction.java:226) ~[Vivecraft.jar:?] at org.vivecraft.client_vr.provider.openvr_lwjgl.MCOpenVR.processInputAction(MCOpenVR.java:1007) ~[Vivecraft.jar:?] at org.vivecraft.client_vr.provider.openvr_lwjgl.MCOpenVR.processInputs(MCOpenVR.java:379) ~[Vivecraft.jar:?] at org.vivecraft.client_vr.provider.openvr_lwjgl.MCOpenVR.poll(MCOpenVR.java:363) ~[Vivecraft.jar:?] at net.minecraft.client.MinecraftClient.handler$bjm000$vivecraft$toggleVRState(MinecraftClient.java:11036) ~[client-intermediary.jar:?] at net.minecraft.class_310.method_1523(class_310.java) ~[client-intermediary.jar:?] at net.minecraft.client.MinecraftClient.run(MinecraftClient.java:888) ~[client-intermediary.jar:?] at net.minecraft.client.main.Main.main(Main.java:265) ~[1.20.4.jar:?] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) ~[fabric-loader-0.15.11.jar:?] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.15.11.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.15.11.jar:?]

✅ Expected Behavior

No crash, handle gracefully.

🥽 Headset Details

Quest 2, 3, Pro
QuestCraft Version: 5.0

ℹ️ Anything else?

Unsure if changes should be made to OC to prevent invalid handle being passed back, might be in violation of OpenVR default behavior?

Could also patch Vivecraft to not crash if a invalid handle error is passed back.

@thejudge156 thejudge156 added the bug Something isn't working label Jun 5, 2024
@thejudge156 thejudge156 assigned CADIndie and thejudge156 and unassigned CADIndie Jun 5, 2024
@Cartrigger Cartrigger added the fixed This bug has been fixed in a new release. label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed This bug has been fixed in a new release.
Projects
None yet
Development

No branches or pull requests

3 participants