🦋 Changeset detected

Latest commit: 292c849

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/astro/@qwikdev/create-astro@229

npm i https://pkg.pr.new/QwikDev/astro/@qwikdev/astro@229

commit: 292c849

Hey Jack,
Seems like a much more elegant solution than my proposal and from what I've tested this has resolved the issue.
But I'll defer to the Dev that logged the issue to confirm.

While we're here - what do you think about the below check function?
Just putting it out there as an idea.

Proposed updated code:

async function check(this: RendererContext, component: unknown) {
  try {
    const isComponent =  isQwikComponent(component);
    if(!isComponent) {
      throw new Error("Component is not a Qwik component");
    }
    return isComponent;
  } catch (error) {
    console.error("Error in check function of @qwikdev/astro: ", error);
    return false;
  }
}

Terminal Output:

Error in check function of @qwikdev/astro:  Error: Component is not a Qwik component

Open to feedback on this Change as I understand that you may not want a full error to be thrown, and could just console.error instead?

We don't want to throw an error because the checked component may belong to another renderer, we're just seeing if it belongs to the Qwik renderer.