Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: CK_TIME_KERNEL used by default #1780

Open
trixirt opened this issue Dec 27, 2024 · 4 comments · May be fixed by #1794
Open

[Issue]: CK_TIME_KERNEL used by default #1780

trixirt opened this issue Dec 27, 2024 · 4 comments · May be fixed by #1794

Comments

@trixirt
Copy link
Contributor

trixirt commented Dec 27, 2024

Problem Description

CK_TIME_KERNEL is defined here always a 1. https://github.com/ROCm/composable_kernel/blob/develop/include/ck/ck.hpp#L20

It is used here when launching kernels https://github.com/ROCm/composable_kernel/blob/develop/include/ck/host_utility/kernel_launch.hpp#L20

Going through a slower runtime path
And throwing extremely noisy warnings at least on Fedora.
'printf' was marked unused but was used [-Wused-but-marked-unused]
slowing down the build.

CK_TIME_KERNEL should be off by default and controlled by a top level cmake variable.

Operating System

Fedora Rawhide

CPU

ALL

GPU

AMD Instinct MI300X

Other

No response

ROCm Version

ROCm 6.0.0

ROCm Component

Composable Kernel

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@ppanchad-amd
Copy link

Hi @trixirt. Internal ticket has been created to fix this issue. Thanks!

@lucbruni-amd lucbruni-amd linked a pull request Jan 6, 2025 that will close this issue
@lucbruni-amd
Copy link

Hi @trixirt,

After discussing with the team, it has been decided that the ckProfiler kernel timing is crucial in verifying correctness and measuring performance, and should not be controllable by CMake flags.

It is possible that you are experiencing false compiler warnings, and I noticed you are using an old ROCm version, 6.0.0. Could you try updating ROCm to the latest version and letting me know whether your build experience remains? Thank you!

@trixirt
Copy link
Contributor Author

trixirt commented Jan 10, 2025

I am working on 6.3.1

If it is always needed, then set the default to ON.

@lucbruni-amd
Copy link

Thanks for clarifying your current ROCm version. I've reopened and updated the PR based on the team's needs and your request. The default will be ON, but CK_TIME_KERNEL will be toggleable according to the PR.

I will let you know when there are further developments regarding the PR. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants