Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many boundaries in transfer system and restrucuring of boundaries in general #25

Open
1 task done
LauraMaier opened this issue Aug 31, 2022 · 2 comments · May be fixed by #102
Open
1 task done

Too many boundaries in transfer system and restrucuring of boundaries in general #25

LauraMaier opened this issue Aug 31, 2022 · 2 comments · May be fixed by #102
Assignees
@LauraMaier

Comments

@LauraMaier
Copy link
Contributor

LauraMaier commented Aug 31, 2022 •
edited by FWuellhorst
Loading

There is an array of fluid boundary models in the following models:

  • BESMod.Systems.Hydraulical.Transfer.RadiatorTransferSystem
  • BESMod.Systems.Hydraulical.Transfer.UFHTransferSystem

The problem with that is that boundaries specify reference pressure and temperature levels for each circuit.
Here, we have parallel fluid flow so that only one overall circuit exists and thus only one reference pressure and temperature level are necessary.

Exemplary picture:
image

How do we solve this problem?

  • We place the boundaries in the distribution system
@LauraMaier LauraMaier self-assigned this Aug 31, 2022
@github-actions
Copy link

Branch 25-Too-many-boundaries-in-transfer-system-and-restrucuring-of-boundaries-in-general created!

@FWuellhorst FWuellhorst mentioned this issue Nov 8, 2022
Merged
FWuellhorst added a commit that referenced this issue Nov 9, 2022
@FWuellhorst @larissakuehn @DaJansenGit
Fix issue #6, #24, #28, #27, and #25
c264147 
Co-authored-by: Larissa Kühn <[email protected]>
Co-authored-by: fabian.wuellhorst <[email protected]>
Co-authored-by: David Jansen <[email protected]>
@FWuellhorst
Copy link
Contributor

Similar to boundaries, we should rethink the placement of pumps. This is confusing when having distribution systems with direct connections.

All boundaries and pumps must go inside the distribution system!

@FWuellhorst FWuellhorst mentioned this issue Apr 18, 2024
Open
@FWuellhorst FWuellhorst linked a pull request Dec 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LauraMaier LauraMaier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

77 pressure losses and distribution RWTH-EBC/BESMod
2 participants
@FWuellhorst @LauraMaier