Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect types reported in error for non-matching types in non-equi join #6069

Closed
tdhock opened this issue Apr 10, 2024 · 3 comments
Closed
Assignees

Comments

@tdhock
Copy link
Member

tdhock commented Apr 10, 2024

Hi! I noticed that the error message for non-equi join is incorrect, when types do not match

point.dt <- data.table(data.i=1L)
seg.dt <- data.table(first.i=1L, last.i=2)
seg.dt[point.dt, on=.(first.i<=data.i,last.i>=data.i)]
# Error in bmerge(i, x, leftcols, rightcols, roll, rollends, nomatch, mult,  : 
#   typeof x.first.i (integer) != typeof i.data.i (double)

The type of i.data.i is integer, not double. The error message should be changed.

@Nj221102 Nj221102 self-assigned this Apr 11, 2024
@venom1204
Copy link
Contributor

can you guide me a little bit regarding this issue
do we only need to change the bmerge.r file in the R folder @tdhock .

@ben-schwen
Copy link
Member

@tdhock it seems that this issue has been fixed by #6603

@tdhock
Copy link
Member Author

tdhock commented Dec 21, 2024

right, now the merge works (no error)

> seg.dt[point.dt, on=.(first.i<=data.i,last.i>=data.i)]
   first.i last.i
     <int>  <int>
1:       1      1

@tdhock tdhock closed this as completed Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants