New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress deprecation of substitute() on LHS of := #6649

Open

MichaelChirico opened this issue Dec 10, 2024 · 0 comments

Assignees

Milestone

Member

MichaelChirico commented Dec 10, 2024

data.table/R/data.table.R

Lines 1133 to 1136 in 436bd6c

    
           #6033 revdep. Slowly deprecate in 1.17.0. Caller has given us `dt[, substitute(names(.SD))]` which means 
        
           # jsub is actually substitute(names(.SD)) instead of just names(.SD) 
        
           if (lhs %iscall% 'substitute') 
        
             lhs = eval(lhs, parent.frame(), parent.frame())

Assigning to @ColeMiller1 who I think has the best context on what to do next here. Should we just add an appropriate warning in this branch?

MichaelChirico added this to the 1.17.0 milestone

MichaelChirico assigned ColeMiller1

MichaelChirico modified the milestones: 1.17.0, 1.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment