Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw :max_diffs_reached from Diffs class #4

Open
geeksam opened this issue Jan 14, 2021 · 0 comments
Open

Don't throw :max_diffs_reached from Diffs class #4

geeksam opened this issue Jan 14, 2021 · 0 comments

Comments

@geeksam
Copy link
Contributor

geeksam commented Jan 14, 2021

If client code tries to use Diffs outside the context of CheckPlease::Compare#perform, there's a possibility that we'll throw that symbol, which will almost certainly surprise the programmer (since throw/catch is pretty niche in Rubyland)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant