Added sulfur chunk energy source to auto-evo #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are currently in feature freeze until the next release. |
|
So based on the Discord discussion, this piece of code needs updating in ChunkCompoundPressure: var compoundATP = cache.GetCompoundGeneratedFrom(compound, atp, microbeSpecies, patch.Biome);
var energyBalance = cache.GetEnergyBalanceForSpecies(microbeSpecies, patch.Biome);
// Penalize species that don't actually need the compound generated by the chunk
score *= MathF.Min(compoundATP / energyBalance.TotalConsumption, 1);so that it properly evaluates chunk compounds that are turned into intermediate compounds before those turn into ATP |
|
I had forgot about this, but I just remembered again. I fixed the main issue you were having. |
|
So should this now actually work? If so that's huge news. |
|
I tested in auto-evo exploring tool and this seems to work so I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description of What This PR Does
Makes auto-evo to know about the added sulfur chunks. Sadly it seems auto-evo doesn't want to fill the miches. So this is marked as a draft until someone can figure out how to fix that.
Related Issues
closes #5761
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.