Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

No delete button for comments #44

Open
RTLShadow opened this issue Aug 17, 2014 · 7 comments
Open

No delete button for comments #44

RTLShadow opened this issue Aug 17, 2014 · 7 comments

Comments

@RTLShadow
Copy link
Contributor

I wrote some test comments in the Lulzbot Begonia page and now I can't delete them. perhaps that's something we need.

@traverseda
Copy link
Member

Yeah, and an edit button. I'm not too familiar with that subsystem. It also needs a decent limited markdown, like reddit comments.

@RTLShadow
Copy link
Contributor Author

Yeah, are you sanitizing your inputs and such to avoid injections?

@traverseda
Copy link
Member

Sanitizing the output mostly. It's part of the django templating system. I'm very careful if I'm ever pushing raw html to be included inline in a template. Like the readme files.

There's been at least two separated users created to try and run XSS attacks.

There's no point where we're dealing with "raw" input, it's all python unicode being used with an sqlalchemy style api, so there's not risk there.

@RTLShadow
Copy link
Contributor Author

Alrighty. Definitely take a look and see how hard it would be to implement markdown in the comments and readme.md.

@traverseda
Copy link
Member

It's already in readme.md, just not the comments

@traverseda
Copy link
Member

Looks like it wouldn't be too hard. But prioritization. I'm going to work on getting the CDN properly sorted out, and on the multiuploader page.

@traverseda
Copy link
Member

Fucking full time employment and it's time usage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants