Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Automated Testing of ResultFsNonRealDataVerificationFailed #510

Open
fvig2001 opened this issue Jan 10, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good first issues to work on for new contributors not planned but open to a PR I do not intend on working on this myself, but I would not be opposed to an implementation.

Comments

@fvig2001
Copy link

fvig2001 commented Jan 10, 2025

Overview

Ryujinx checks corruption of NSP/XCI at startup and does not add them to the list. However, ResultFsNonRealDataVerificationFailed is only checked when game is run and causing Ryujinx to crash.

I would like to request a feature that will allow Ryujinx to automatically check each game via either while it is adding the rom to the list or as a dedicated tool that runs games in the background to check.

Smaller details

Maybe run the game in the background just to see if it encounters ResultFsNonRealDataVerificationFailed then kill it after 45 seconds. Maybe run it as another user and delete the save later.

Nature of request

Improve corrupt rom detection.

Why would this feature be useful?

To help people like me who backup their dumps to be able to know their dumps are good.

@fvig2001 fvig2001 added the enhancement New feature or request label Jan 10, 2025
@fvig2001 fvig2001 changed the title [Feature Request] Automated Testing of corruption [Feature Request] Automated Testing of ResultFsNonRealDataVerificationFailed Jan 10, 2025
@EmeraldStar0
Copy link

If this is implemented, there should be a popup that tells you that one of your games is corrupted, as it may confuse people wondering where their game is

@GreemDev GreemDev added good first issue Good first issues to work on for new contributors not planned but open to a PR I do not intend on working on this myself, but I would not be opposed to an implementation. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good first issues to work on for new contributors not planned but open to a PR I do not intend on working on this myself, but I would not be opposed to an implementation.
Projects
None yet
Development

No branches or pull requests

3 participants