Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for all services/controllers #32

Open
3 of 5 tasks
delbertlegg opened this issue Feb 17, 2019 · 0 comments
Open
3 of 5 tasks

Add unit tests for all services/controllers #32

delbertlegg opened this issue Feb 17, 2019 · 0 comments
Labels
testing Testing improvements

Comments

@delbertlegg
Copy link
Contributor

delbertlegg commented Feb 17, 2019 •
edited
Loading

With latest refactor adding DI for services, the existing tests are more integration than unit tests. Tests should cover:

  • Agency Services
  • Taxonomy Services
  • Location Services
  • Request Utilities
  • Query utilities

V1 routes are deprecated, so testing would be nice but not high priority. V2 routes should staty as passthrough only so no tests are necessary. Models should stay as constructors only.
@delbertlegg delbertlegg added the testing Testing improvements label Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delbertlegg