Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: demo preparation #106

Closed
wants to merge 4 commits into from
Closed

Conversation

j-chad
Copy link
Contributor

@j-chad j-chad commented Apr 3, 2022

Description

Aggregate fix of things needed for demo:

  • README update
  • Small bug fixes
    • Schema incorrectly exported
    • set default env to production

Resolves #105

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Leave blank if not applicable

I have completed these steps when making this pull request:

  • I have checked that the PR is from a forked repository
  • I have assigned my name to the issue
  • I have moved the issue to the In Progress column
  • I have labelled the PR appropriately
  • I have assigned people responsible to the PR

Before opening the PR for review:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have moved the linked issue to the Review in Progress column

@j-chad j-chad added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Apr 3, 2022
@j-chad j-chad self-assigned this Apr 3, 2022
@j-chad j-chad requested a review from a team as a code owner April 3, 2022 06:52
@j-chad j-chad requested a review from justcrossheaven April 3, 2022 06:52
const PostModel =
mongoose.models.Post || mongoose.model<IPost>('Post', postSchema);
const PostModel = mongoose.model<IPost>('Post', postSchema);
Copy link
Collaborator

@fishmonger45 fishmonger45 Apr 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure I need these in for test:dev because of some recompilation error of with models if it's missing. Are you removing these for any particular reason?

Comment on lines +13 to +14
): Promise<typeof database | undefined> {
if (config.get('environment') === 'testing') return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I really should have done this instead of a resolve hack lol

// Connect to MongoDB database
connectFn().then(
connect().then(
Copy link
Contributor

@justcrossheaven justcrossheaven Apr 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing "TypeError: Cannot read properties of undefined (reading 'then')" for npm run test

@j-chad j-chad closed this Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo Preparation
3 participants