Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't select an algorithm for SVDFactorization #488

Open
avik-pal opened this issue Mar 29, 2024 · 3 comments
Open

Don't select an algorithm for SVDFactorization #488

avik-pal opened this issue Mar 29, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@avik-pal
Copy link
Member

Selecting an algorithm for SVDFactorization will cause it to fail for CUDA. Possible solutions:

  1. Keep it as nothing and use the default versions used in the downstream package
@avik-pal avik-pal added the bug Something isn't working label Mar 29, 2024
@ChrisRackauckas
Copy link
Member

I don't get what this means.

@avik-pal
Copy link
Member Author

SVDFactorization() = SVDFactorization(false, LinearAlgebra.DivideAndConquer())
sets the algorithm as DivideAndConquer, the CUSOLVER ones which is dispatched via svd(::CuArray) don't map directly to the LinearAlgebra ones so svd(::CuArray; alg = DivideAndConquer() is an error

@ChrisRackauckas ChrisRackauckas added the good first issue Good for newcomers label Mar 31, 2024
@ChrisRackauckas
Copy link
Member

I see. We had to do the same before with QR factorization pivoting choices. This is an easy thing to fix, good first issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants