Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the onTileTap inside of FilledCell to onTapDown #390

Open
henycave opened this issue Jul 13, 2024 · 0 comments
Open

change the onTileTap inside of FilledCell to onTapDown #390

henycave opened this issue Jul 13, 2024 · 0 comments
Assignees
@shubham-jitiya-simform
Labels
breaking change Defines a request that might contain breaking change. Update major package version after fixing this enhancement New feature or request priority:2 Bug/Enhancement with priority level 2.

Comments

@henycave
Copy link

On the MonthView's FilledCell, instead of using the onTileTap, we should use onTapDown since it exposes the TapDownDetails, This helps when showing an overlay because we can use it to get the offset.
@ParthBaraiya ParthBaraiya added enhancement New feature or request priority:2 Bug/Enhancement with priority level 2. breaking change Defines a request that might contain breaking change. Update major package version after fixing this labels Sep 13, 2024
@shubham-jitiya-simform shubham-jitiya-simform self-assigned this Jan 6, 2025
shubham-jitiya-simform added a commit that referenced this issue Jan 6, 2025
@shubham-jitiya-simform
fix: Fixes issue #390: ✨ Update tap events in month view
76ae1c4
shubham-jitiya-simform added a commit that referenced this issue Jan 6, 2025
@shubham-jitiya-simform
fix: Fixes issue #390: ✨ Update tap events in month view
dd91cad
shubham-jitiya-simform added a commit that referenced this issue Jan 6, 2025
@shubham-jitiya-simform
feat: Fixes issue #390: ✨ Update tap events in month view
4c2b058
Open
7 tasks
shubham-jitiya-simform added a commit that referenced this issue Jan 6, 2025
@shubham-jitiya-simform
feat: Fixes issue #390: ✨ Update tap events in month view
6830749
shubham-jitiya-simform added a commit that referenced this issue Jan 7, 2025
@shubham-jitiya-simform
feat: Fixes issue #390: ✨ Update tap events in month view
b54de36
shubham-jitiya-simform added a commit that referenced this issue Jan 7, 2025
@shubham-jitiya-simform
feat: Fixes issue #390: ✨ Update tap events in month view
b910a30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubham-jitiya-simform shubham-jitiya-simform

Labels
breaking change Defines a request that might contain breaking change. Update major package version after fixing this enhancement New feature or request priority:2 Bug/Enhancement with priority level 2.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ParthBaraiya @henycave @shubham-jitiya-simform