Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaterialProtobuf overhaul #119

Open
jsrehak opened this issue Jan 23, 2019 · 0 comments
Open

MaterialProtobuf overhaul #119

jsrehak opened this issue Jan 23, 2019 · 0 comments
Labels
major Involves multiple classes across multiple top level namespaces. testing Related to testing helpers and support classes.

Comments

@jsrehak
Copy link
Contributor

jsrehak commented Jan 23, 2019

The MaterialProtobuf class and testing needs to be overhauled.

The testing is comprehensive but is difficult to read and modify. There are a number of tests that are unnecessary and definition of specific test Materials is not really needed. It might make sense to replace all the definition of the properties of the test materials with randomly generated materials.

In doing so, the references to the dealii::ParameterHandler can also be replaced (#116) and google style can be enforced (#106)
@jsrehak jsrehak added major Involves multiple classes across multiple top level namespaces. testing Related to testing helpers and support classes. labels Jan 23, 2019
@jsrehak jsrehak changed the title MaterialProtobuf overhaul MaterialProtobuf overhaul Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major Involves multiple classes across multiple top level namespaces. testing Related to testing helpers and support classes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsrehak