Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on resource creation : double check if contentType return same extension as file extension #146

Open
bourgeoa opened this issue Oct 15, 2019 · 1 comment

Comments

@bourgeoa
Copy link
Contributor

see SolidOS/folder-pane#5

on resource creation solid-ui in https://github.com/solid/solid-ui/blob/master/src/widgets/dragAndDrop.js/uploadFiles check if contentType match file extension L170-173

     var extension = mime.extension(theFile.type)
     if (theFile.type !== mime.lookup(theFile.name)) {
       suffix = '_.' + extension
       console.log('MIME TYPE MISMATCH -- adding extension: ' + suffix)

The same control is made in NSSv5.2.0 in resource-mapper.mapUrlToFile L108-110
The control should be deleted from solid-ui

@bourgeoa
Copy link
Contributor Author

PR #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant