Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC battery backup not used #67

Open
kevinmoll14 opened this issue Oct 24, 2019 · 0 comments
Open

RTC battery backup not used #67

kevinmoll14 opened this issue Oct 24, 2019 · 0 comments

Comments

@kevinmoll14
Copy link

@jnettlet: Commit df7f7ef introduces a bug where the battery backup for the RTC is disabled.

On first-ever powerup of the PCF, the chip returns a random time and battery backup is not enabled. The kernel driver enables the battery backup. However, if the random time is outside the checked range introduced by this commit, the kernel driver does a software reset of the PCF. This causes the battery backup to be disabled again.

This is a problem because every time the user removes power from the device, on next boot a random time will be returned and battery backup disabled. This keeps happening until the random time just happens to fall within the valid range of times you've constrained the clock to have.

The software reset should be performed before the battery backup is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant