Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the development continuing? #6

Closed
MehmetCagriK opened this issue Aug 3, 2023 · 7 comments
Closed

Is the development continuing? #6

MehmetCagriK opened this issue Aug 3, 2023 · 7 comments

Comments

@MehmetCagriK
Copy link
Collaborator

Hey @Sollimann , for a company project, I decided use AirSim with Rust API. Yours were the only one. I am at the experimenting phase with examples and found some minor mistakes. I will soon create some PRs. Will you continue to manage this project?

@Sollimann
Copy link
Owner

Hey, yes feel free to add PRs. I'll review them :)

Take note that I have created a separate library for msgpack-rpc itself, so you might want to take a look there as well if you encounter any issues: https://github.com/Sollimann/msgpack-rpc

One bug that I have found that I haven't been able to resolve is that I'm getting a buffer overflow for large payloads such as images and pointclouds and is why I haven't been able to implement those endpoints yet. Nevertheless, its very strange in my opinion that the Airsim team chooses to use msgpack-rpc for video-streaming and streaming of pointclouds. Something like webrtc or grpc would be much better suited for that purpose.

@MehmetCagriK
Copy link
Collaborator Author

MehmetCagriK commented Aug 3, 2023

I am switching to another Airsim fork which seems to be well maintained(has over 90 comments after fork, including one commit last week). The fork is maintained by a company called SWARM under this repo: https://github.com/CodexLabsLLC/Colosseum . You might want to check it out. I will also check Rust API with their fork, and will inform you whether it works with minimal changes or not.

They are trying to improve infrastructure. Right now, they are supporting Unreal Engine 5.2 out of the box(I had to downgrade to 4.27 in main Airsim repo). Another one of their goals is replacing msgpack with ZeroMQ or Google FlatBuffers.
Colosseum Development Goals . I am not experienced in those protocols but you may be interested in what they are doing.

Thanks for your work!

@Sollimann
Copy link
Owner

Okay, thanks for the info!

It's good choice moving away from msgpack-rpc. Its a bad choice of protocol for large payloads, streaming api, strict typing, multilanguage operability, etc..

@MehmetCagriK
Copy link
Collaborator Author

Development is continuing.

@MehmetCagriK
Copy link
Collaborator Author

MehmetCagriK commented Aug 3, 2023

Hello again, it seems I do not have write privileges to this repository. When I tried push a new branch to base my merge request, I had permission denied error.
And fyi, your API works with Colosseum + Unreal Engine 5.2 nearly out of the box. You just need to apply the fix I mentioned in CodexLabsLLC/Colosseum#59 but no other changes are necessary.

@MehmetCagriK MehmetCagriK reopened this Aug 3, 2023
@Sollimann
Copy link
Owner

Added you as a collaborator to the project. You should have an invite pending :)

@MehmetCagriK
Copy link
Collaborator Author

I got it now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants