OutputManager API ambiguity.

[dkfellows]

In the OutputManager, there are two methods getResultFile with different numbers of parameters. How should the JAX-RS engine tell which to call in each case?

Right now, they're mapped to the paths:

• /output/{projectId}/{id}/{filename:.*}
• /output/{id}/{filename:.*}

For the actual path /output/123/456/789/abc.txt, which one will be picked is entirely ambiguous! This is not a good state of affairs. We either need to make the software able to pick one clearly each time (e.g., by adding a RE to the matchers for projectId and id so that the software can clearly figure out exactly one of them to use in all cases) or we need to remove one of them and insist that either the projectId is always supplied or never supplied.

[rowleya]

I can see the issue here - I think the form without projectId was for backwards compatibility, but was also provided before sub-folders were supported! My suggestion would be to remove the backward compatibility at this point as it is unlikely we even have any files from jobs prior to this point any more with a 1-month deletion schedule!

In summary, keep the form:

/output/{projectId}/{id}/{filename:.*}

and get rid of the other one.