Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to store and use boards #365

Open
Christian-B opened this issue Oct 9, 2023 · 2 comments
Open

No need to store and use boards #365

Christian-B opened this issue Oct 9, 2023 · 2 comments
Assignees
Milestone

Comments

@Christian-B
Copy link
Member

Follow up to #350

BMPConnectionData is always created with boards=[0]

So remove that altogether

Including its usage in https://github.com/SpiNNakerManchester/SpiNNMan/blob/master/spinnman/messages/scp/impl/set_power.py

@Christian-B Christian-B self-assigned this Oct 9, 2023
@rowleya
Copy link
Member

rowleya commented Oct 10, 2023

I guess that is because we 1) never use a multi-board machine without spalloc and 2) spalloc is now in Java. I guess if that is the recommended use, we may as well make that a non parameter.

@Christian-B
Copy link
Member Author

Likely to be removed but I suggest leaving until spin 2 fully implemented,

@Christian-B Christian-B added this to the Bluesky milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants