Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control coverage ignored? #124

Closed
mike1813 opened this issue Dec 13, 2023 · 2 comments
Closed

Control coverage ignored? #124

mike1813 opened this issue Dec 13, 2023 · 2 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@mike1813
Copy link
Member

In control strategies composed only of mandatory controls, the blocking effect of the CSG is supposed to be the minimum between the CSG default blocking effect, and the coverage levels of its mandatory controls.

I am reasonably sure this was tested using the small SSM-Testing domain model when it was inserted into the code. But I noticed that it doesn't make any difference to reduce the coverage levels of controls.

Needs investigating and fixing.

@mike1813 mike1813 self-assigned this Dec 13, 2023
@mike1813
Copy link
Member Author

This is presumably a bug in the Risk Calculator, so I'll take a look at it myself when I get a moment.

@kenmeacham kenmeacham added the bug Something isn't working label Dec 17, 2024
@mike1813 mike1813 added the duplicate This issue or pull request already exists label Jan 9, 2025
@mike1813
Copy link
Member Author

mike1813 commented Jan 9, 2025

Reviewed by @mike1813 : this is the same issue as later raised in #215, which has been addressed.

@mike1813 mike1813 closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants