Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create source code QA guidelines #168

Open
danshearer opened this issue May 1, 2024 · 0 comments
Open

Create source code QA guidelines #168

danshearer opened this issue May 1, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@danshearer
Copy link
Member

This is originally from @scp93ch .

Should we have a set of sonarlint rules that must pass? (for new code?)

Should we have a checkstyle ruleset that must be applied? (for new code?)

Comment originally from @danshearer : Whatever the answer, it can only indeed be for new code. Even though we will be visiting every file in the system-modeller tree, and even though we will be making at least one mass change, no, we will not be taking the opportunity to reformat code or correct spelling en masse. That breaks the ability to do diffs with old code, which causes great pain and possibly pestilence.

@danshearer danshearer self-assigned this May 1, 2024
@kenmeacham kenmeacham added the enhancement New feature or request label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants