Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Universal SSR support request #237

Open
tylerforsythe opened this issue Jul 7, 2021 · 4 comments
Open

Angular Universal SSR support request #237

tylerforsythe opened this issue Jul 7, 2021 · 4 comments
Assignees

Comments

@tylerforsythe
Copy link

Hello,

Are there any plans to support Angular Universal SSR? That is, checking isPlatformBrowser() before attempting to reference the window object? Thanks!

@Stabzs
Copy link
Owner

Stabzs commented Jul 7, 2021

It wasn't something that was explicitly planned. That said, it seems like the only issue is that window.setTimeout calls are being executed server-side and wrapping with a check would enable SSR?

@tylerforsythe
Copy link
Author

My understanding is that yes: protecting just those calls would enable SSR. I'd do it myself but don't know the first thing about developing/testing a node module.

@Stabzs
Copy link
Owner

Stabzs commented Jul 7, 2021

This isn't something I've spent much time testing either, although the change is trivial. I have a set of changes I'm putting together for release this week. I'll add this and I can make future adjustments based on implementation feedback.

@Stabzs Stabzs self-assigned this Jul 7, 2021
@tylerforsythe
Copy link
Author

That'd be excellent; thank you so much! Looking forward to trying it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants