Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining issues with try_add_constraint_and_split #115

Open
Stoeoef opened this issue Sep 10, 2024 · 0 comments
Open

Remaining issues with try_add_constraint_and_split #115

Stoeoef opened this issue Sep 10, 2024 · 0 comments

Comments

@Stoeoef
Copy link
Owner

Stoeoef commented Sep 10, 2024

Since there have been several bugs related to try_add_constraint_and_split, I've added a simple property test that adds random constraint edges and looks for irregularities.

It found two additional edge cases so far that I'm working on at the moment - more edge cases might be uncovered once I've fixed these.

In the meantime, this issue is just a strong recommendation to use f64 based coordinate types when using try_add_constraint_and_split - while they are affected by the same issues in theory, they are much more resilient in practice.

I'll close this issue once the prop passes with a decent amount of samples and is contained in the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant