-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors in tables missing #210
Comments
Yeah, with the current way we used the Fortunately, this is one of those cases that could be fixed easily with the latter approach. I'll take a look at fixing this later, or if you feel like getting your hands dirty, pull requests are welcome. |
In my opinion, it'd be nice to have a UserCSS option to completely disable colour overrides in wikitable cells that have custom colours. Some tables use colour legends to convey information, and I would much rather be blinded slightly and consume that information that have to turn off the entire theme and get flashbanged. An example of this can be found here: Another example can be found here: Thanks, |
I also noticed the coloring in the tables on https://en.wikipedia.org/wiki/Multicast_address has been removed. |
As is, these colors are made with inline styles in most places as the practice of using classes and template styles didn't happen until fairly recently in Wikipedia editing history. Hence, the reason they're so prevalent, and such pervasive use of We concluded a while back that the best way to solve it would be a rewrite of the non-mobile style (we already rewrote the mobile one), but since then, the Vector Modern skin was released and made default, and it's grown it's own dark mode, reducing the priority of a rewrite. If anyone is interested in finding all the places that happen to affect these tables (there's a lot) and putting them behind an option, pull requests are certainly welcome. |
I noticed the color is missing in tables. While this isn't a HUGE issue, it makes reading the table a little difficult.
How am I to keep track of my housewives...
Native Version with color in table:
Wiki-Dark without color in table
The text was updated successfully, but these errors were encountered: