Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) reuse dockerfile since it gets cacheds and reused anyway in my … #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(fix) reuse dockerfile since it gets cacheds and reused anyway in my … #604

wants to merge 1 commit into from

Conversation

crosspolar
Copy link
Contributor

I think we don't need to refer to an image (which hasn't been build) according to this docker/compose#7343 (comment) and can build all

@crosspolar crosspolar linked an issue Dec 22, 2024 that may be closed by this pull request
pull access denied for tapir-image, repository does not exist or may require 'docker login': denied: requested access to the resource is denied for images depending on non-existing tapir-image` #603
Open
Theophile-Madet
Theophile-Madet requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@Theophile-Madet Theophile-Madet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this solves #603 : I deleted all the containers, images and volumes from my machine and could still run docker compose up without building and without docker attempting to pull the image.

What command did you run when getting the errors?

If these changes don't solve #603 , I would keep the reference to the image as it makes clear that all 3 containers use the same image and makes sure that they stay the same.

@crosspolar
Copy link
Contributor Author

The thing is: it works but docker still throws the errors. I would still not simply ignore it.
I used (after docker system prune -a to be sure) just docker compose up.

$ docker --version
Docker version 27.4.1, build b9d17ea

@crosspolar
Copy link
Contributor Author

With this changes the errors don't appear.

@Theophile-Madet
Copy link
Contributor

When you say "it works", do you mean the celery containers work too or just the web container?

@Theophile-Madet
Copy link
Contributor

What OS are you on?

@crosspolar
Copy link
Contributor Author

All containers running

$ docker ps
CONTAINER ID   IMAGE                                      COMMAND                  CREATED          STATUS          PORTS                                                                                NAMES
de4d7f93437e   tapir-image                                "bash -c 'poetry ins…"   30 seconds ago   Up 29 seconds                                                                                        tapir-celery-1
0189ef34cf53   tapir-image                                "bash -c 'poetry ins…"   30 seconds ago   Up 29 seconds                                                                                        tapir-celery-beat-1
0f98ac0928b3   tapir-image                                "bash -c 'poetry ins…"   30 seconds ago   Up 29 seconds                                                                                        tapir-web-1
e52cdea8c4d3   selenium/standalone-firefox-debug:latest   "/opt/bin/entry_poin…"   30 seconds ago   Up 30 seconds   4444/tcp, 0.0.0.0:5900->5900/tcp, :::5900->5900/tcp                                  tapir-selenium-1
125bb397451a   jwilder/nginx-proxy                        "/app/docker-entrypo…"   30 seconds ago   Up 29 seconds   0.0.0.0:8000->80/tcp, [::]:8000->80/tcp, 0.0.0.0:8001->443/tcp, [::]:8001->443/tcp   tapir-nginx-proxy-1
09c9a0d01d3b   postgres:14-alpine                         "docker-entrypoint.s…"   30 seconds ago   Up 30 seconds   0.0.0.0:5432->5432/tcp, :::5432->5432/tcp                                            tapir-db-1
4c7ac95d9197   osixia/openldap                            "/container/tool/run…"   30 seconds ago   Up 30 seconds   0.0.0.0:389->389/tcp, :::389->389/tcp, 636/tcp                                       tapir-openldap-1
3952c31664d6   redis:alpine                               "docker-entrypoint.s…"   30 seconds ago   Up 30 seconds   6379/tcp                                                                             tapir-redis-1

on Linux Mint

@Theophile-Madet
Copy link
Contributor

So if the error message pops and the containers still run, then the error message is wrong? That's weird.
I'm on Ubuntu through WLS with Docker 27.4.0, could be a version difference but I didn't find anything relevant in the changelog of Docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theophile-Madet Theophile-Madet Theophile-Madet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@crosspolar @Theophile-Madet