Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture taxjar timeout exceptions in exception handler #61

Open
Noah-Silvera opened this issue Apr 21, 2021 · 0 comments
Open

Capture taxjar timeout exceptions in exception handler #61

Noah-Silvera opened this issue Apr 21, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Noah-Silvera
Copy link
Member

Noah-Silvera commented Apr 21, 2021

In some situations when Taxjar is down, a Rack::Timeout::RequestTimeoutException is thrown.

When this occurs, the exception handler does not catch this error, as it does not inherit from standard errors.

We can be reasonably confident that if this exception is thrown from a line which calls the taxjar api, that the taxjar API is unresponsive / down.

Therefore, we should catch this exception in API calls and delegate it to the configured exception handler.

This ticket arose out of the discussion in #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant