Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve :api configuration affordances #20

Open
RickMoynihan opened this issue Oct 14, 2020 · 0 comments
Open

Improve :api configuration affordances #20

RickMoynihan opened this issue Oct 14, 2020 · 0 comments

Comments

@RickMoynihan
Copy link
Member

It's a pain to have to set two very similar keys in :swirrl.auth0/client config:

:api "https://dev-kkt-m758.eu.auth0.com/api/v2/"

and

:endpoint "https://dev-kkt-m758.eu.auth0.com"

I'd suggest that the client should append /api/v2/ to the :endpoint if the :api key is not specified, and use :api in preference if it is set. Given that the client is presumably a v2 client is this even necessary, is it not really just a :v2 client implementation? If so is there a need to override this behaviour?

@RickMoynihan RickMoynihan changed the title Improve configuration affordances Improve :api configuration affordances Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant