Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group information not updated when reactions are renamed #59

Open
pranasag opened this issue Oct 27, 2023 · 0 comments
Open

Group information not updated when reactions are renamed #59

pranasag opened this issue Oct 27, 2023 · 0 comments

Comments

@pranasag
Copy link

pranasag commented Oct 27, 2023

Hi Brett et al,

I would like to submit an issue regarding the use of Groups/Subsystems. Two cases when it goes wrong:

  • When renaming reactions with rxn.changeId(), the following happens: the group information is not updated, it seems, and the exported model does not any group/subsystems assigned to it. Also, slightly unrelated, but it seems that the reaction bound objects also do not get updated.

The next one seems to be duplicate, see #22

  • When deleting reactions model.deleteReactionAndBounds(): the member is not removed from the group(s) it belonged to. COBRApy complains about loading such a SBML file, so now I have written a brute-force loop to check whether there are "ghost" members in each group.

Fixes would be appreciated!
Cheers
Pranas

@pranasag pranasag changed the title Group information not updated when reactions are removed or renamed Group information not updated when reactions are renamed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant