Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced 'break' with 'beginning' for page|line|column|gathering in Guidelines and Specs #2634

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

trishaoconnor
Copy link
Contributor

@trishaoconnor trishaoconnor commented Dec 10, 2024

Replaced 'break' with 'beginning' for page|line|column|gathering in the following files from the Guidelines and Specs:

-     page beginning (<pb>)
-     column beginning (<cb>)
-     att.breaking
-     parameter (<param>)
-     model (<model>)
-     att.edition
-     att.milestoneUnit
-     WD Non Standard Characters
-     SG Gentle Introduction
-     PH Primary Sources
-     NH Non Hierarchical
-     HD Header
-     FT Tables Formulae Graphics
-     DS Default Text Structure
-     DI Print Dictionaries
-     CO Core Elements
-     CH Language Character Sets

There were no mentions of 'break' in the prose of <gb> but I deleted an superfluous space in the prose

The requested changes to <lb> are addressed in PR #2633.

@trishaoconnor trishaoconnor added this to the Guidelines 4.9.0 milestone Dec 10, 2024
@GusRiva GusRiva linked an issue Dec 14, 2024 that may be closed by this pull request
4 tasks
@ebeshero ebeshero requested a review from sydb January 12, 2025 00:23
@ebeshero ebeshero self-assigned this Jan 12, 2025
@ebeshero
Copy link
Member

@sydb Might as well have a look at this while you're at it?

Copy link
Member

@sydb sydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The majority of my suggestions for change, here, are underpinned by my strong distaste for using the noun “beginning” unless it is being used to gloss an element itself or very specifically about the beginning of a feature. Others may disagree.

@@ -426,7 +426,7 @@ dates, and predefined value lists.</note></p></div>
individual characters, the overall typesetting process also
follows specific rules of how to calculate the distance between
characters, how much whitespace occurs between words, at which
points line breaks might occur and so forth. </p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This use of the term has nothing to do with our <lb> element, and perhaps should just be left as “break”.

Copy link
Contributor Author

@trishaoconnor trishaoconnor Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about rewriting the above without "break" and to avoid repetition of "occurs" and "occur":

"... at which points new lines might begin and so forth"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, I like that; but I think I would like a more complete re-write better:

It might nevertheless be helpful to put some of the terminology used for the rendering process in the context of the discussion of this chapter. As was mentioned above, Unicode encodes abstract characters, not specific glyphs. For any process that makes characters visible, however, concrete, specifically designed glyph shapes have to be used. For a printing process, for example, these shapes describe exactly at which point ink has to be put on the paper and which areas have to be left blank. If we want to print a character from the Latin script, besides the selection of the overall glyph shape, this process also requires that a specific weight and size of the font has been selected, and to what degree the shape should be slanted. Beyond individual characters, the overall typesetting process also needs to follow specific rules for calculating the distance between characters, for determining how much whitespace occurs between any two words, and how long each line should be (and thus at which points a new line begins), and so forth.

(Feel free to ignore, use, or tweak.)

@@ -329,7 +329,7 @@ problem for text encoders. Suppose, for example, that we wish to
investigate a diachronic English corpus for occurrences of
<mentioned>tea-pot</mentioned> and <mentioned>teapot</mentioned>, to
find evidence for the point at which this compound becomes
lexicalized. Any case where the word is hyphenated across a linebreak,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This use of the term has nothing to do with our <lb> element, and perhaps should just be left as “line break”. (Note the space — 18 of the 25 occurences of "line.?break" in the Guidelines have a space. (One has a hyphen, and six have the single word version.)

Copy link
Contributor Author

@trishaoconnor trishaoconnor Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further down on line 353, "line division" is used. For consistency, I've rewritten line 332 using "division" instead of "beginning" and "break". Hopefully, this substitution is acceptable?

"Any case where the word is hyphenated across a linebreak..."

Thank you very much, too, for spotting the different renderings of the term throughout the Guidelines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. But with respect to the different renderings of the term, no pat on the back for just finding them; I have not gone out and fixed them, yet. 😄

P5/Source/Guidelines/en/CO-CoreElements.xml Outdated Show resolved Hide resolved
P5/Source/Guidelines/en/CO-CoreElements.xml Outdated Show resolved Hide resolved
P5/Source/Guidelines/en/CO-CoreElements.xml Show resolved Hide resolved
P5/Source/Guidelines/en/WD-NonStandardCharacters.xml Outdated Show resolved Hide resolved
P5/Source/Guidelines/en/WD-NonStandardCharacters.xml Outdated Show resolved Hide resolved
P5/Source/Specs/att.breaking.xml Outdated Show resolved Hide resolved
P5/Source/Specs/model.xml Outdated Show resolved Hide resolved
P5/Source/Specs/param.xml Outdated Show resolved Hide resolved
@martindholmes
Copy link
Contributor

@trishaoconnor Just letting you know I've just cherry-picked a single-character commit fix from dev into this branch just to make sure it didn't cause any issues. It was a typo in the boustrophedon section of WD-NonStandardCharacters.xml which just needed an added s, found by @sydb. Doesn't affect any of the other stuff in your branch.

@trishaoconnor
Copy link
Contributor Author

Thank you very much @sydb for your thorough review and thank you too @martindholmes for fixing that typo and merging it to the PR.

I appreciate your point @sydb and thank you very much for highlighting the passages where "beginning" isn't an appropriate substitution for "break". I confess that I still have a preference for using "beginning" instead of "break" and would be in favour of rewriting these passages along similar lines to the example that you supplied above:

<p>In the following lines from the <title level="a">Dream of the Rood</title>, the words <mentioned>lāðost</mentioned> and <mentioned>reord-berendum</mentioned> each start on one line and continue on the next.</p>

Of course, if the general consensus is to revert to "break" instead, I'll happily do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace * break with * beginning
5 participants