-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color shifts in video exports #20
Comments
Some models can have color shifting, does it happen with any other encoder? |
I tested the same RealSR JPEG model in your app and in the Hybrid (Windows) app. If the encoder in your app is always ffmpeg, then maybe the command line needs extra parameters which carry over the exact colour metadata of the source? Hybrid uses Vapoursynth scripts which seem to include lines which maintain color properties (I don't fully understand this stuff unfortunately). |
Does rife have color shifting? Here is what I've done Run REAL-Video_enhancer interpolate on it with pytorch, rife 2.22-lite Opening both the downloaded video and the interpolated video; pausing them both on the first frame. I don't know if this is a rife thing, or a RVE(real-video-enhancer) thing. |
Late to this discussion but I think the problem might be that ffmpeg by default converts RGB to YUV using bt601, regardless of the resolution (at least according to this article I found). I noticed some videos I was interpolating had noticeable color shifting, so I tested this by adding This is kinda just a bandaid for bt709 YUV videos, to fix the problem entirely you'd prob need to |
Could this amendment be made to the current working MacOS version please? |
I won't make changes to the outdated build, sorry. |
Your project is fantastic, however the color of the ProRes export does not exactly match the color of the source.
I'm using a MacBook Pro 2019.
In my tests, it's mainly shades of blue which seem to noticeably shift in the export.
Can the next version please have this fixed? In comparison, the Windows version of the "Hybrid" application by Selur can process RealSR and create exports which exactly match the source video color.
The text was updated successfully, but these errors were encountered: