Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Cafeteria to Canteen #115

Open
COM8 opened this issue Dec 10, 2022 · 0 comments
Open

Rename Cafeteria to Canteen #115

COM8 opened this issue Dec 10, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@COM8
Copy link
Member

COM8 commented Dec 10, 2022

The cafeteria rating endpoint uses conflicting names. It uses data from the eat-api, but calls everything Cafeteria* instead of Canteen*. Also it uses the enum_names for canteens instead of canteen_id.

I will work on a PR to resolve this once #114 has been merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@COM8 @CommanderStorm