-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] clicking on news does not open news source #344
Comments
What news are you clicking on? (can you attach a screenshot) Idk, if there are good solutions to scrape the text from these images and check if some of the contained text is a link => link there.. |
Transferred to the backend, as this is likely where the issue comes from. |
Sorry some additional info: for example tum thesis printing, but also Talk Food Texture Engineering, Drachenbootrennen and all others i see in the latest news tab. I think it would be nice if it just opened the source it is referncing at the bottom of the news text. For the TU Film it works correctly and opens the link when clicking on the different movies. |
I can offer some insights into this: in the beginning we opened the corresponding URL in an In-App-Webview. But after, presumably, changes to the backend the URL was always a link to the password-protected newsspread site. To offer at least some better way to display the information we opted for a full-screen image view. I don't think scraping the image on the client-side would be smart due to performance reasons, we could do that in the backend. If possible, I would opt to bring back public URLs. In general, I was thinking about moving solely to the TUM RSS since these are the only news that affect every student of TUM and are not faculty-specific. But that's another matter 😄 imo this is therefore also not a bug ^^ |
Tum's feed does contain lots of "less related" things (Read: PR). => lets discuss the approach for news parsing on the next team meeting. |
I think that's debatable but we could think about filtering a bit more depending on the degree of the user. But yes, let's discuss that next meeting :) |
Describe the bug
Currently when clicking on news in the news tab of the app it does not redirect or open the origin of the news but instead just opens a full view of the preview image.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When clicking on a news article i want to be able to read more context about it or open the source in a browser window.
The text was updated successfully, but these errors were encountered: