Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential for Runtime Json Improvements #61

Open
TheNitesWhoSay opened this issue Aug 21, 2020 · 0 comments
Open

Potential for Runtime Json Improvements #61

TheNitesWhoSay opened this issue Aug 21, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@TheNitesWhoSay
Copy link
Owner

TheNitesWhoSay commented Aug 21, 2020

Currently I solve the problem of reading types known at runtime time with "Json::Generic"s - relying on polymorphism - but I could potentially (though not necessarily, will need performance testing before and after) cut a lot of memory usage and processing overhead using a type index (or type hash or whatnot) and some sort of union'd type.

In this example I'm using tuple, which is of course not union'd and thus not addressing memory usage, but it demonstrates dynamically retrieving the type from a pack of template parameters. https://godbolt.org/z/z1o818

Generics are also currently ~800 lines of code with tons of repetition for the pure virtual methods, getting this metric down would also be nice if possible.

@TheNitesWhoSay TheNitesWhoSay added the enhancement New feature or request label Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant