Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a channel is deleted the bot should disconnect #164

Open
Croydon opened this issue Dec 24, 2016 · 5 comments
Open

When a channel is deleted the bot should disconnect #164

Croydon opened this issue Dec 24, 2016 · 5 comments
Assignees
Milestone

Comments

@Croydon
Copy link
Contributor

Croydon commented Dec 24, 2016

Right now, if one deletes an IRC channel Notifico will just stay connected to it.

@minduser00
Copy link

Not only occurs when deleting the channel, but also occurs if the webhook is deleted. even deleting the project also does not disconnect from the channel and remains on the network after kicking it out of the channel.

@Dav1dde
Copy link
Contributor

Dav1dde commented Oct 11, 2018

Just kick the bot if you don't want it anymore.

@minduser00
Copy link

It was the first thing that occurred to me when I saw that the bot remained after deleting the channel and the project, but even so, more than 12 hours later, the bot remains connected to the IRC network.

@Dav1dde
Copy link
Contributor

Dav1dde commented Oct 11, 2018

It will stay forever until the bot is restarted, there is no mechanism that checks for active networks and channels. It joins when there is a message to send and then stays.

@TkTech TkTech self-assigned this Jun 26, 2021
@TkTech TkTech added this to the Version 2.0.0 milestone Jun 26, 2021
@TkTech
Copy link
Owner

TkTech commented Jun 26, 2021

We should disconnect a configurable (say, 10 minutes) time after the last channel on a given network is deleted. We don't want to join and leave immediately if a user is quickly deleting the only channel on a network, as this will be an instant banhammer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants